Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common, ngram_cache: added const reference for std::pair<> and std::tuple<> more 16 bytes: #7270

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

common, ngram_cache: added const reference for std::pair<> and std::tuple<> more 16 bytes: #7270

wants to merge 4 commits into from

Conversation

GermanAizek
Copy link
Contributor

  • std::pair<llama_ngram, llama_ngram_cache_part> (72 bytes -> 8 bytes)
  • std::tuple<std::string, float> (40 bytes -> 8 bytes)

@GermanAizek
Added const reference for std::pair<> and std::tuple<> more 16 bytes:
ced5bfe 
- std::pair<llama_ngram, llama_ngram_cache_part> (72 bytes -> 8 bytes)
- std::tuple<std::string, float> (40 bytes -> 8 bytes)
@GermanAizek
Copy link
Contributor Author

MacOS test is failed.

@mofosyne mofosyne added refactoring Refactoring Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix labels May 14, 2024
@JohannesGaessler
Copy link
Collaborator

Good catch with the &. Does the compilation work if you just remove the const?

@mofosyne mofosyne marked this pull request as draft May 17, 2024 03:02
@GermanAizek
Merge branch 'ggerganov:master' into const-ref-pair
ce4a390
@GermanAizek
Added const reference for std::pair<> and std::tuple<> more 16 bytes:
f2e4d92 
- std::pair<llama_ngram, llama_ngram_cache_part> (72 bytes -> 8 bytes)
- std::tuple<std::string, float> (40 bytes -> 8 bytes)
@GermanAizek
Copy link
Contributor Author

GermanAizek commented May 20, 2024 •
edited
Loading

Good catch with the &. Does the compilation work if you just remove the const?

@JohannesGaessler, for MacOS again not working only & without const
More: https://github.com/ggerganov/llama.cpp/actions/runs/9152668091/job/25160468570?pr=7270

@GermanAizek GermanAizek marked this pull request as ready for review August 15, 2024 21:50
Nexesenex added a commit to Nexesenex/croco.cpp that referenced this pull request Aug 16, 2024
@Nexesenex @GermanAizek
common, ngram_cache: added const reference for std::pair<> and std::…
14d93c7 
…tuple<> more 16 bytes: ggerganov#7270

Co-Authored-By: Herman Semenov <[email protected]>
@GermanAizek
Copy link
Contributor Author

GermanAizek commented Aug 25, 2024 •
edited
Loading

@mofosyne @JohannesGaessler @ggerganov only CI / macOS-latest-make is failed. Why macos cmake is succesful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Refactoring Review Complexity : Low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GermanAizek @JohannesGaessler @mofosyne